• Robert Griesemer's avatar
    encoding/binary: fix error message · 1dba6eb4
    Robert Griesemer authored
    In the process, simplified internal sizeOf and
    dataSize functions. Minor positive impact on
    performance. Added test case.
    
    benchmark                         old ns/op     new ns/op     delta
    BenchmarkReadSlice1000Int32s      14006         14122         +0.83%
    BenchmarkReadStruct               2508          2447          -2.43%
    BenchmarkReadInts                 921           928           +0.76%
    BenchmarkWriteInts                2086          2081          -0.24%
    BenchmarkWriteSlice1000Int32s     13440         13497         +0.42%
    BenchmarkPutUvarint32             28.5          26.3          -7.72%
    BenchmarkPutUvarint64             81.3          76.7          -5.66%
    
    benchmark                         old MB/s     new MB/s     speedup
    BenchmarkReadSlice1000Int32s      285.58       283.24       0.99x
    BenchmarkReadStruct               27.90        28.60        1.03x
    BenchmarkReadInts                 32.57        32.31        0.99x
    BenchmarkWriteInts                14.38        14.41        1.00x
    BenchmarkWriteSlice1000Int32s     297.60       296.36       1.00x
    BenchmarkPutUvarint32             140.55       151.92       1.08x
    BenchmarkPutUvarint64             98.36        104.33       1.06x
    
    Fixes #6818.
    
    LGTM=r
    R=r
    CC=golang-codereviews
    https://golang.org/cl/149290045
    1dba6eb4
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal/syscall Loading commit data...
io Loading commit data...
lib9 Loading commit data...
libbio Loading commit data...
liblink Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...
sudo.bash Loading commit data...