• Dmitry Vyukov's avatar
    cmd/gc: don't copy []byte during string concatenation · 205ae07c
    Dmitry Vyukov authored
    Consider the following code:
    
    s := "(" + string(byteSlice) + ")"
    
    Currently we allocate a new string during []byte->string conversion,
    and pass it to concatstrings. String allocation is unnecessary in
    this case, because concatstrings does memorize the strings for later use.
    This change uses slicebytetostringtmp to construct temp string directly
    from []byte buffer and passes it to concatstrings.
    
    I've found few such cases in std lib:
    
    	s += string(msg[off:off+c]) + "."
    	buf.WriteString("Sec-WebSocket-Accept: " + string(c.accept) + "\r\n")
    	bw.WriteString("Sec-WebSocket-Key: " + string(nonce) + "\r\n")
    	err = xml.Unmarshal([]byte("<Top>"+string(data)+"</Top>"), &logStruct)
    	d.err = d.syntaxError("invalid XML name: " + string(b))
    	return m, ProtocolError("malformed MIME header line: " + string(kv))
    
    But there are much more in our internal code base.
    
    Change-Id: I42f401f317131237ddd0cb9786b0940213af16fb
    Reviewed-on: https://go-review.googlesource.com/3163Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    205ae07c
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal/syscall Loading commit data...
io Loading commit data...
lib9 Loading commit data...
libbio Loading commit data...
liblink Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...