• Andrei Tudor Călin's avatar
    internal/poll: use more fine-grained locking in Splice · 24fb2e01
    Andrei Tudor Călin authored
    The previous code acquired a read lock on src and a write lock on
    dst for the entire duration of Splice. This resulted in deadlock,
    in a situation akin to the following:
    
    Splice is blocking, waiting to read from src.
    
    The caller tries to close dst from another goroutine, but Close on
    dst blocks in runtime.semacquire, because Splice is still holding a
    write lock on it, and the Close didn't unblock any I/O.
    
    The caller cannot unblock the read side of Splice through other means,
    because they are stuck waiting in dst.Close().
    
    Use more fine-grained locking instead: acquire the read lock on src
    just before trying to splice from the source socket to the pipe,
    and acquire the write lock on dst just before trying to splice from
    the pipe to the destination socket.
    
    Fixes #25985
    
    Change-Id: I264c91c7a69bb6c5e28610e2bd801244804cf86d
    Reviewed-on: https://go-review.googlesource.com/120317
    Run-TryBot: Aram Hăvărneanu <aram@mgk.ro>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    24fb2e01
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...