• Alberto Donizetti's avatar
    encoding/xml: simplify slice-growing logic in rawToken · 252ee909
    Alberto Donizetti authored
    It appears that old code (from 2009) in xml.(*Decoder).rawToken
    replicates append's slice-growing functionality by allocating a new,
    bigger backing array and then calling copy.
    
    Simplifying the code by replacing it with a single append call does
    not seem to hurt performance:
    
    name         old time/op    new time/op    delta
    Marshal-4      11.2µs ± 1%    11.3µs ±10%    ~     (p=0.069 n=19+17)
    Unmarshal-4    28.6µs ± 1%    28.4µs ± 1%  -0.60%  (p=0.000 n=20+18)
    
    name         old alloc/op   new alloc/op   delta
    Marshal-4      5.78kB ± 0%    5.78kB ± 0%    ~     (all equal)
    Unmarshal-4    8.61kB ± 0%    8.27kB ± 0%  -3.90%  (p=0.000 n=20+20)
    
    name         old allocs/op  new allocs/op  delta
    Marshal-4        23.0 ± 0%      23.0 ± 0%    ~     (all equal)
    Unmarshal-4       189 ± 0%       190 ± 0%  +0.53%  (p=0.000 n=20+20)
    
    Change-Id: Ie580d1216a44760e611e63dee2c339af5465aea5
    Reviewed-on: https://go-review.googlesource.com/86655Reviewed-by: 's avatarDaniel Martí <mvdan@mvdan.cc>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    252ee909
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...