• Issac Trotts's avatar
    cmd/go: no longer eval symlinks in inDir · 25aaeaa9
    Issac Trotts authored
    Evaluating the symlinks was slowing down test cache checks.
    
    Fixes #26562
    Fixes #26726
    
    	ijt:~/gopath/src/issue26562$ cat foo_test.go
    	package foo_test
    
    	import (
    		"fmt"
    		"os"
    		"path/filepath"
    		"testing"
    	)
    
    	// package and imports snipped
    	func TestCache(t *testing.T) {
    		tmp := os.TempDir()
    		for i := 0; i < 1000000; i++ {
    			os.Stat(filepath.Join(tmp, fmt.Sprintf("%d", i)))
    		}
    	}
    	ijt:~/gopath/src/issue26562$ time ~/github/go/bin/go test -count=1
    	PASS
    	ok      issue26562      9.444s
    
    	real    0m10.021s
    	user    0m2.344s
    	sys     0m7.835s
    	ijt:~/gopath/src/issue26562$ time ~/github/go/bin/go test .
    	ok      issue26562      (cached)
    
    	real    0m0.802s
    	user    0m0.551s
    	sys     0m0.306s
    
    Change-Id: I3ce7f7b68bb5b9e802069f277e79e1ed3c162622
    Reviewed-on: https://go-review.googlesource.com/127635
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    25aaeaa9
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...