• Russ Cox's avatar
    cmd/go: apply same per-package flags to compile and link of test · 2c296dc8
    Russ Cox authored
    If package strings has a particular set of gcflags, then the strings_test
    pseudo-package built as part of the test binary started inheriting the
    same flags in CL 81496, to fix #22831.
    
    Now the package main and final test binary link built as part of the
    strings test binary also inherit the same flags, to fix #22994.
    
    I am slightly uneasy about reusing package strings's flags for
    package main, but the alternative would be to introduce some
    kind of special case, which I'd be even more uneasy about.
    
    This interpretation preserves the Go 1.9 behavior of existing
    commands like:
    
    	go test -c -ldflags=-X=mypkg.debugString=foo mypkg
    
    Fixes #22994.
    
    Change-Id: I9ab83bf1a9a6adae530a7715b907e709fd6c1b5d
    Reviewed-on: https://go-review.googlesource.com/83879
    Run-TryBot: Russ Cox <rsc@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    2c296dc8
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...