• Josh Bleecher Snyder's avatar
    testing: make benchmarking faster · a12cc719
    Josh Bleecher Snyder authored
    The number of estimated iterations required to reach the benchtime is multiplied by a safety margin (to avoid falling just short) and then rounded up to a readable number. With an accurate estimate, in the worse case, the resulting number of iterations could be 3.75x more than necessary: 1.5x for safety * 2.5x to round up (e.g. from 2eX+1 to 5eX).
    
    This CL reduces the safety margin to 1.2x. Experimentation showed a diminishing margin of return past 1.2x, although the average case continued to show improvements down to 1.05x.
    
    This CL also reduces the maximum round-up multiplier from 2.5x (from 2eX+1 to 5eX) to 2x, by allowing the number of iterations to be of the form 3eX.
    
    Both changes improve benchmark wall clock times, and the effects are cumulative.
    
    From 1.5x to 1.2x safety margin:
    
    package		old s	new s	delta
    bytes		163	125	-23%
    encoding/json	27	21	-22%
    net/http	42	36	-14%
    runtime		463	418	-10%
    strings		82	65	-21%
    
    Allowing 3eX iterations:
    
    package		old s	new s	delta
    bytes		163	134	-18%
    encoding/json	27	23	-15%
    net/http	42	36	-14%
    runtime		463	422	-9%
    strings		82	72	-12%
    
    Combined:
    
    package		old s	new s	delta
    bytes		163	112	-31%
    encoding/json	27	20	-26%
    net/http	42	30	-29%
    runtime		463	346	-25%
    strings		82	60	-27%
    
    LGTM=crawshaw, r, rsc
    R=golang-codereviews, crawshaw, r, rsc
    CC=golang-codereviews
    https://golang.org/cl/105990045
    a12cc719
Name
Last commit
Last update
..
iotest Loading commit data...
quick Loading commit data...
allocs.go Loading commit data...
benchmark.go Loading commit data...
benchmark_test.go Loading commit data...
cover.go Loading commit data...
example.go Loading commit data...
export_test.go Loading commit data...
testing.go Loading commit data...