• Dave Cheney's avatar
    runtime/cgo: encode BLX directly, fixes one clang build error on arm · d1b29137
    Dave Cheney authored
    Fixes #8348.
    
    Trying to work around clang's dodgy support for .arch by reverting to the external assembler didn't work out so well. Minux had a much better solution to encode the instructions we need as .word directives which avoids .arch altogether.
    
    I've confirmed with gdb that this form produces the expected machine code
    
    Dump of assembler code for function crosscall_arm1:
       0x00000000 <+0>:	push	{r4, r5, r6, r7, r8, r9, r10, r11, r12, lr}
       0x00000004 <+4>:	mov	r4, r0
       0x00000008 <+8>:	mov	r5, r1
       0x0000000c <+12>:	mov	r0, r2
       0x00000010 <+16>:	blx	r5
       0x00000014 <+20>:	blx	r4
       0x00000018 <+24>:	pop	{r4, r5, r6, r7, r8, r9, r10, r11, r12, pc}
    
    There is another compilation failure that blocks building Go with clang on arm
    
    # ../misc/cgo/test
    # _/home/dfc/go/misc/cgo/test
    /tmp/--407b12.s: Assembler messages:
    /tmp/--407b12.s:59: Error: selected processor does not support ARM mode `blx r0'
    clang: error: assembler command failed with exit code 1 (use -v to see invocation)
    FAIL	_/home/dfc/go/misc/cgo/test [build failed]
    
    I'll open a new issue for that
    
    LGTM=iant
    R=iant, minux
    CC=golang-codereviews
    https://golang.org/cl/158180047
    d1b29137
Name
Last commit
Last update
..
asm_386.s Loading commit data...
asm_amd64.s Loading commit data...
asm_arm.s Loading commit data...
asm_nacl_amd64p32.s Loading commit data...
callbacks.c Loading commit data...
cgo.go Loading commit data...
dragonfly.c Loading commit data...
freebsd.c Loading commit data...
gcc_386.S Loading commit data...
gcc_amd64.S Loading commit data...
gcc_android.c Loading commit data...
gcc_android_arm.c Loading commit data...
gcc_arm.S Loading commit data...
gcc_darwin_386.c Loading commit data...
gcc_darwin_amd64.c Loading commit data...
gcc_dragonfly_386.c Loading commit data...
gcc_dragonfly_amd64.c Loading commit data...
gcc_fatalf.c Loading commit data...
gcc_freebsd_386.c Loading commit data...
gcc_freebsd_amd64.c Loading commit data...
gcc_freebsd_arm.c Loading commit data...
gcc_linux_386.c Loading commit data...
gcc_linux_amd64.c Loading commit data...
gcc_linux_arm.c Loading commit data...
gcc_netbsd_386.c Loading commit data...
gcc_netbsd_amd64.c Loading commit data...
gcc_netbsd_arm.c Loading commit data...
gcc_openbsd_386.c Loading commit data...
gcc_openbsd_amd64.c Loading commit data...
gcc_setenv.c Loading commit data...
gcc_util.c Loading commit data...
gcc_windows_386.c Loading commit data...
gcc_windows_amd64.c Loading commit data...
iscgo.c Loading commit data...
libcgo.h Loading commit data...
netbsd.c Loading commit data...
openbsd.c Loading commit data...
setenv.c Loading commit data...