• David Crawshaw's avatar
    cmd/7g: fix ACMP entry in progtable · 33448d96
    David Crawshaw authored
    On arm64, CMP $foo, R is encoded as from=$foo, reg=R, not as from=$foo,
    to=R. The progtable entry for ACMP incorrectly described the latter
    form. Because of this, the registerizer was not accounting the registers
    used in CMP instructions and was incorrectly re-assigning those registers.
    
    This was an old problem, but it only became apparent after b115c35e
    (cmd/internal/gc: move cgen, regalloc, et al to portable code). Previous
    to this commit, the compiler used a slightly larger register set for the
    temps than it used for register variables. Since it had plenty registers
    dedicated to temps, the registers used in CMP instruction never clashed
    with registers assigned to register variables.
    
    Fixes #10253
    
    Change-Id: Iedf4bd882bd59440dff310ac0f81e0f53d80d7ed
    Reviewed-on: https://go-review.googlesource.com/8387Reviewed-by: 's avatarAram Hăvărneanu <aram@mgk.ro>
    Reviewed-by: 's avatarRob Pike <r@golang.org>
    Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    Reviewed-by: 's avatarMinux Ma <minux@golang.org>
    33448d96
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...