• Austin Clements's avatar
    runtime: fix check for vacuous page boundary rounding · 336dad2a
    Austin Clements authored
    sysUnused (e.g., madvise MADV_FREE) is only sensible to call on
    physical page boundaries, so scavengelist rounds in the bounds of the
    region being released to the nearest physical page boundaries.
    However, if the region is smaller than a physical page and neither the
    start nor end fall on a boundary, then rounding the start up to a page
    boundary and the end down to a page boundary will result in end < start.
    Currently, we only give up on the region if start == end, so if we
    encounter end < start, we'll call madvise with a negative length and
    the madvise will fail.
    
    Issue #16644 gives a concrete example of this:
    
        start = 0x1285ac000
        end   = 0x1285ae000 (1 8K page)
    
    This leads to the rounded values
    
        start = 0x1285b0000
        end   = 0x1285a0000
    
    which leads to len = -65536.
    
    Fix this by giving up on the region if end <= start, not just if
    end == start.
    
    Fixes #16644.
    
    Change-Id: I8300db492dbadc82ac1ad878318b36bcb7c39524
    Reviewed-on: https://go-review.googlesource.com/27230Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    336dad2a
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x/net Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...