• Alberto Donizetti's avatar
    cmd/gofmt: skip gofmt idempotency check on known issue · 3649fe29
    Alberto Donizetti authored
    gofmt's TestAll runs gofmt on all the go files in the tree and checks,
    among other things, that gofmt is idempotent (i.e. that a second
    invocation does not change the input again).
    
    There's a known bug of gofmt not being idempotent (Issue #24472), and
    unfortunately the fixedbugs/issue22662.go file triggers it. We can't
    just gofmt the file, because it tests the effect of various line
    directives inside weirdly-placed comments, and gofmt moves those
    comments, making the test useless.
    
    Instead, just skip the idempotency check when gofmt-ing the
    problematic file.
    
    This fixes go test on the cmd/gofmt package, and a failure seen on the
    longtest builder.
    
    Updates #24472
    
    Change-Id: Ib06300977cd8fce6c609e688b222e9b2186f5aa7
    Reviewed-on: https://go-review.googlesource.com/130377Reviewed-by: 's avatarDaniel Martí <mvdan@mvdan.cc>
    Reviewed-by: 's avatarRobert Griesemer <gri@golang.org>
    Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    3649fe29
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...