• Russ Cox's avatar
    runtime: remove assumption that noptrdata data bss noptrbss are ordered and contiguous · 378c2515
    Russ Cox authored
    The assumption can be violated by external linkers reordering them or
    inserting non-Go sections in between them. I looked briefly at trying
    to write out the _go_.o in external linking mode in a way that forced
    the ordering, but no matter what there's no way to force Go's data
    and Go's bss to be next to each other. If there is any data or bss from
    non-Go objects, it's very likely to get stuck in between them.
    
    Instead, rewrite the two places we know about that make the assumption.
    I grepped for noptrdata to look for more and didn't find any.
    
    The added race test (os/exec in external linking mode) fails without
    the changes in the runtime. It crashes with an invalid pointer dereference.
    
    Fixes #9133.
    
    LGTM=dneil
    R=dneil
    CC=dvyukov, golang-codereviews, iant
    https://golang.org/cl/179980043
    378c2515
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal/syscall Loading commit data...
io Loading commit data...
lib9 Loading commit data...
libbio Loading commit data...
liblink Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...
sudo.bash Loading commit data...