• Ben Shi's avatar
    cmd/internal/obj/arm64: fix two issues in the assembler · 3d6e4ec0
    Ben Shi authored
    There are two issues in the arm64 assembler.
    
    1. "CMPW $0x22220000, RSP" is encoded to 5b44a4d2ff031b6b, which
       is the combination of "MOVD $0x22220000, Rtmp" and
       "NEGSW Rtmp, ZR".
       The right encoding should be a combination of
       "MOVD $0x22220000, Rtmp" and "CMPW Rtmp, RSP".
    
    2. "AND $0x22220000, R2, RSP" is encoded to 5b44a4d25f601b00,
       which is the combination of "MOVD $0x22220000, Rtmp" and
       an illegal instruction.
       The right behavior should be an error report of
       "illegal combination", since "AND Rtmp, RSP, RSP" is invalid
       in armv8.
    
    This CL fixes the above 2 issues and adds more test cases.
    
    fixes #25557
    
    Change-Id: Ia510be26b58a229f5dfe8a5fa0b35569b2d566e7
    Reviewed-on: https://go-review.googlesource.com/114796
    Run-TryBot: Ben Shi <powerman1st@163.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    Reviewed-by: 's avatarCherry Zhang <cherryyz@google.com>
    3d6e4ec0
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...