• isharipo's avatar
    mime: do a pre-allocation in encodeWord · 3fb3ca08
    isharipo authored
    The preallocated memory size is comparable to bytes.Buffer bootstraping
    array length (bytes.Buffer was used before rewrite to strings.Builder).
    
    Without preallocation, encodeWord does more than one allocation for
    almost any possible input.
    
    The regression happens because bytes.Buffer did a 80-bytes allocation
    at the beginning of encodeWord while strings.Builder did several
    smaller allocations (started with cap=0).
    
    Comparison with reported regression:
    
      name           old time/op    new time/op    delta
      QEncodeWord-4     781ns ± 1%     593ns ± 1%  -24.08%  (p=0.008 n=5+5)
    
      name           old alloc/op   new alloc/op   delta
      QEncodeWord-4      152B ± 0%       80B ± 0%  -47.37%  (p=0.008 n=5+5)
    
      name           old allocs/op  new allocs/op  delta
      QEncodeWord-4      5.00 ± 0%      2.00 ± 0%  -60.00%  (p=0.008 n=5+5)
    
    Comparison with buffer solution (like before strings.Builder, but
    without sync pool for buffer re-using):
    
      name           old time/op    new time/op    delta
      QEncodeWord-4     595ns ± 1%     593ns ± 1%     ~     (p=0.460 n=5+5)
    
      name           old alloc/op   new alloc/op   delta
      QEncodeWord-4      160B ± 0%       80B ± 0%  -50.00%  (p=0.008 n=5+5)
    
      name           old allocs/op  new allocs/op  delta
      QEncodeWord-4      2.00 ± 0%      2.00 ± 0%     ~     (all equal)
    
    We avoid allocation in buf.String(), as expected.
    
    Fixes #25379
    
    Change-Id: I19763f0e593a27390c1a549b86ce6507b489046b
    Reviewed-on: https://go-review.googlesource.com/113235
    Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    3fb3ca08
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...