• Daniel Martí's avatar
    encoding/base64: slight decoding speed-up · 811b187a
    Daniel Martí authored
    First, use a dummy slice access on decode64 and decode32 to ensure that
    there is a single bounds check for src.
    
    Second, move the PutUint64/PutUint32 calls out of these functions,
    meaning that they are simpler and smaller. This may also open the door
    to inlineability in the future, but for now, they both go past the
    budget.
    
    While at it, get rid of the ilen and olen variables, which have no
    impact whatsoever on performance. At least, not measurable by any of the
    benchmarks.
    
    name                 old time/op    new time/op    delta
    DecodeString/2-4       54.3ns ± 1%    55.2ns ± 2%   +1.60%  (p=0.017 n=5+6)
    DecodeString/4-4       66.6ns ± 1%    66.8ns ± 2%     ~     (p=0.903 n=6+6)
    DecodeString/8-4       79.3ns ± 2%    79.6ns ± 1%     ~     (p=0.448 n=6+6)
    DecodeString/64-4       300ns ± 1%     281ns ± 3%   -6.54%  (p=0.002 n=6+6)
    DecodeString/8192-4    27.4µs ± 1%    23.7µs ± 2%  -13.47%  (p=0.002 n=6+6)
    
    name                 old speed      new speed      delta
    DecodeString/2-4     73.7MB/s ± 1%  72.5MB/s ± 2%   -1.55%  (p=0.026 n=5+6)
    DecodeString/4-4      120MB/s ± 1%   120MB/s ± 2%     ~     (p=0.851 n=6+6)
    DecodeString/8-4      151MB/s ± 2%   151MB/s ± 1%     ~     (p=0.485 n=6+6)
    DecodeString/64-4     292MB/s ± 1%   313MB/s ± 3%   +7.03%  (p=0.002 n=6+6)
    DecodeString/8192-4   399MB/s ± 1%   461MB/s ± 2%  +15.58%  (p=0.002 n=6+6)
    
    For #19636.
    
    Change-Id: I0dfbdafa2a41dc4c582f63aef94b90b8e473731c
    Reviewed-on: https://go-review.googlesource.com/113776Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    811b187a
Name
Last commit
Last update
..
base64.go Loading commit data...
base64_test.go Loading commit data...
example_test.go Loading commit data...