• Ian Lance Taylor's avatar
    cmd/cgo, runtime, runtime/cgo: TSAN support for malloc · a5d1a72a
    Ian Lance Taylor authored
    Acquire and release the TSAN synchronization point when calling malloc,
    just as we do when calling any other C function. If we don't do this,
    TSAN will report false positive errors about races calling malloc and
    free.
    
    We used to have a special code path for malloc and free, going through
    the runtime functions cmalloc and cfree. The special code path for cfree
    was no longer used even before this CL. This CL stops using the special
    code path for malloc, because there is no place along that path where we
    could conditionally insert the TSAN synchronization. This CL removes
    the support for the special code path for both functions.
    
    Instead, cgo now automatically generates the malloc function as though
    it were referenced as C.malloc.  We need to automatically generate it
    even if C.malloc is not called, even if malloc and size_t are not
    declared, to support cgo-provided functions like C.CString.
    
    Change-Id: I829854ec0787a80f33fa0a8a0dc2ee1d617830e2
    Reviewed-on: https://go-review.googlesource.com/23260Reviewed-by: 's avatarDmitry Vyukov <dvyukov@google.com>
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarAustin Clements <austin@google.com>
    a5d1a72a
Name
Last commit
Last update
..
asm_386.s Loading commit data...
asm_amd64.s Loading commit data...
asm_arm.s Loading commit data...
asm_arm64.s Loading commit data...
asm_mips64x.s Loading commit data...
asm_nacl_amd64p32.s Loading commit data...
asm_ppc64x.s Loading commit data...
asm_s390x.s Loading commit data...
callbacks.go Loading commit data...
callbacks_traceback.go Loading commit data...
cgo.go Loading commit data...
dragonfly.go Loading commit data...
freebsd.go Loading commit data...
gcc_386.S Loading commit data...
gcc_amd64.S Loading commit data...
gcc_android.c Loading commit data...
gcc_android_386.c Loading commit data...
gcc_android_amd64.c Loading commit data...
gcc_android_arm.c Loading commit data...
gcc_android_arm64.c Loading commit data...
gcc_arm.S Loading commit data...
gcc_arm64.S Loading commit data...
gcc_context.c Loading commit data...
gcc_darwin_386.c Loading commit data...
gcc_darwin_amd64.c Loading commit data...
gcc_darwin_arm.c Loading commit data...
gcc_darwin_arm64.c Loading commit data...
gcc_dragonfly_amd64.c Loading commit data...
gcc_fatalf.c Loading commit data...
gcc_freebsd_386.c Loading commit data...
gcc_freebsd_amd64.c Loading commit data...
gcc_freebsd_arm.c Loading commit data...
gcc_libinit.c Loading commit data...
gcc_libinit_openbsd.c Loading commit data...
gcc_libinit_windows.c Loading commit data...
gcc_linux_386.c Loading commit data...
gcc_linux_amd64.c Loading commit data...
gcc_linux_arm.c Loading commit data...
gcc_linux_arm64.c Loading commit data...
gcc_linux_mips64x.c Loading commit data...
gcc_linux_ppc64x.c Loading commit data...
gcc_linux_s390x.c Loading commit data...
gcc_mips64x.S Loading commit data...
gcc_mmap.c Loading commit data...
gcc_netbsd_386.c Loading commit data...
gcc_netbsd_amd64.c Loading commit data...
gcc_netbsd_arm.c Loading commit data...
gcc_openbsd_386.c Loading commit data...
gcc_openbsd_amd64.c Loading commit data...
gcc_ppc64x.S Loading commit data...
gcc_s390x.S Loading commit data...
gcc_setenv.c Loading commit data...
gcc_signal_darwin_armx.c Loading commit data...
gcc_signal_darwin_lldb.c Loading commit data...
gcc_solaris_amd64.c Loading commit data...
gcc_traceback.c Loading commit data...
gcc_util.c Loading commit data...
gcc_windows_386.c Loading commit data...
gcc_windows_amd64.c Loading commit data...
iscgo.go Loading commit data...
libcgo.h Loading commit data...
mmap.go Loading commit data...
netbsd.go Loading commit data...
openbsd.go Loading commit data...
setenv.go Loading commit data...
signal_darwin_arm.s Loading commit data...
signal_darwin_arm64.s Loading commit data...
signal_darwin_armx.go Loading commit data...