• Dmitri Shuralyov's avatar
    crypto/x509: fix panic in TestEnvVars, improve style · 441fd133
    Dmitri Shuralyov authored
    This panic happens when the test fails due to the returned number of
    certificates (r.certs) being less than expected by test case (tc.cns).
    When i == len(r.certs) in the for loop, r.certs[i] will cause an index
    out of range panic.
    
    Also improve readability, consistency and style of the code. Use the
    more common "got x, want y" pattern. See https://golang.org/s/style#useful-test-failures
    for reference (and grep codebase for most common occurrences). Add a
    comment, and remove blank line separating two blocks that are both
    related to verifying that len(r.certs) == len(tc.cns). This should
    help with readability.
    
    Remove space after colon in call to t.Fatal, since it adds spaces
    between its arguments.
    
    Fixes #20801.
    
    Change-Id: I40476103f1b5a0fa74b05637c250926b571c92fd
    Reviewed-on: https://go-review.googlesource.com/46715
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    441fd133
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...