• Josh Bleecher Snyder's avatar
    [dev.ssa] cmd/compile: make failed nil checks panic · 463858e6
    Josh Bleecher Snyder authored
    Introduce pseudo-ops PanicMem and LoweredPanicMem.
    PanicMem could be rewritten directly into MOVL
    during lowering, but then we couldn't log nil checks.
    
    With this change, runnable nil check tests pass:
    
    GOSSAPKG=main go run run.go -- nil*.go
    
    Compiler output nil check tests fail:
    
    GOSSAPKG=p go run run.go -- nil*.go
    
    This is due to several factors:
    
    * SSA has improved elimination of unnecessary nil checks.
    * SSA is missing elimination of implicit nil checks.
    * SSA is missing extra logging about why nil checks were removed.
    
    I'm not sure how best to resolve these failures,
    particularly in a world in which the two backends
    will live side by side for some time.
    For now, punt on the problem.
    
    Change-Id: Ib2ca6824551671f92e0e1800b036f5ca0905e2a3
    Reviewed-on: https://go-review.googlesource.com/13474Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    463858e6
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...