• Russ Cox's avatar
    encoding/binary: give LittleEndian, BigEndian specific types · 1451695f
    Russ Cox authored
    Giving them specific types has the benefit that
    binary.BigEndian.Uint32(b) is now a direct call, not an
    indirect via a mutable interface value, so it can potentially
    be inlined.
    
    Recent changes to the spec relaxed the rules for comparison,
    so this code is still valid:
    
    	func isLittle(o binary.ByteOrder) { return o == binary.LittleEndian }
    
    The change does break this potential idiom:
    
    	o := binary.BigEndian
    	if foo {
    		o = binary.LittleEndian
    	}
    
    That must rewrite to give o an explicit binary.ByteOrder type.
    On balance I think the benefit from the direct call and inlining
    outweigh the cost of breaking that idiom.
    
    R=r, r2
    CC=golang-dev
    https://golang.org/cl/2427042
    1451695f
Name
Last commit
Last update
..
archive Loading commit data...
asn1 Loading commit data...
big Loading commit data...
bufio Loading commit data...
bytes Loading commit data...
cmath Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
debug Loading commit data...
ebnf Loading commit data...
encoding Loading commit data...
exec Loading commit data...
exp Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
gob Loading commit data...
hash Loading commit data...
html Loading commit data...
http Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
io Loading commit data...
json Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
netchan Loading commit data...
os Loading commit data...
patch Loading commit data...
path Loading commit data...
rand Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
rpc Loading commit data...
runtime Loading commit data...
scanner Loading commit data...
smtp Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
syslog Loading commit data...
tabwriter Loading commit data...
template Loading commit data...
testing Loading commit data...
time Loading commit data...
try Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
utf16 Loading commit data...
utf8 Loading commit data...
websocket Loading commit data...
xml Loading commit data...
Makefile Loading commit data...
deps.bash Loading commit data...