• Joe Tsai's avatar
    archive/zip: fix regression when writing directories · 4b0c8b01
    Joe Tsai authored
    Several adjustments:
    
    1) When encoding the FileHeader for a directory, explicitly set all of the sizes
    to zero regardless of their prior values. These values are currently populated
    by FileInfoHeader as it calls os.FileInfo.Size regardless of whether the file is
    a directory or not. We avoid fixing FileInfoHeader now as it is too late in the
    release cycle (see #24082).
    
    We silently adjust slightly wrong FileHeader fields as opposed to returning
    an error because the CreateHeader method already does such mutations
    (e.g., for UTF-8 detection, data descriptor, etc).
    
    2) Have dirWriter.Write only return an error if some number of bytes are written.
    Some code still call Write for both normal files and directories, but just pass
    an empty []byte to Write for directories.
    
    Change-Id: I85492a31356107fcf76dc89ceb00a28853754289
    Reviewed-on: https://go-review.googlesource.com/124155
    Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    4b0c8b01
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...