• Austin Clements's avatar
    runtime: yield to GC coordinator after assist completion · 500c88d4
    Austin Clements authored
    Currently it's possible for the GC assist to signal completion of the
    mark phase, which puts the GC coordinator goroutine on the current P's
    run queue, and then return to mutator code that delays until the next
    forced preemption before actually yielding control to the GC
    coordinator, dragging out completion of the mark phase. This delay can
    be further exacerbated if the mutator makes other goroutines runnable
    before yielding control, since this will push the GC coordinator on
    the back of the P's run queue.
    
    To fix this, this adds a Gosched to the assist if it completed the
    mark phase. This immediately and directly yields control to the GC
    coordinator. This already happens implicitly in the background mark
    workers because they park immediately after completing the mark.
    
    This is one of the reasons completion of the mark phase is being
    dragged out and allowing the mutator to allocate without assisting,
    leading to the large heap goal overshoot in issue #11677. This is also
    a prerequisite to making the assist block when it can't pay off its
    debt.
    
    Change-Id: I586adfbecb3ca042a37966752c1dc757f5c7fc78
    Reviewed-on: https://go-review.googlesource.com/12670Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    500c88d4
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...