• Marcel van Lohuizen's avatar
    testing: gracefully handle subtest failing parent’s T · 4c1aff87
    Marcel van Lohuizen authored
    Don’t panic if a subtest inadvertently calls FailNow
    on a parent’s T.  Instead, report the offending subtest
    while still reporting the error with the ancestor test and
    keep exiting goroutines.
    
    Note that this implementation has a race if parallel
    subtests are failing the parent concurrently.
    This is fine:
    Calling FailNow on a parent is considered an error
    in principle, at the moment, and is reported if it is
    detected. Having the race allows the race detector
    to detect the error as well.
    
    Fixes #22882
    
    Change-Id: Ifa6d5e55bb88f6bcbb562fc8c99f1f77e320015a
    Reviewed-on: https://go-review.googlesource.com/97635
    Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
    Reviewed-by: 's avatarKunpei Sakai <namusyaka@gmail.com>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    4c1aff87
Name
Last commit
Last update
..
internal/testdeps Loading commit data...
iotest Loading commit data...
quick Loading commit data...
allocs.go Loading commit data...
allocs_test.go Loading commit data...
benchmark.go Loading commit data...
benchmark_test.go Loading commit data...
cover.go Loading commit data...
example.go Loading commit data...
export_test.go Loading commit data...
helper_test.go Loading commit data...
helperfuncs_test.go Loading commit data...
match.go Loading commit data...
match_test.go Loading commit data...
sub_test.go Loading commit data...
testing.go Loading commit data...
testing_test.go Loading commit data...