• Russ Cox's avatar
    go/build: make TestDependencies check all systems at once · 54a966e3
    Russ Cox authored
    We used to use build.Import to get the dependencies, but that meant
    we had to repeat the check for every possible GOOS/GOARCH/cgo
    combination, which took too long. So we made the test in short mode
    only check the current GOOS/GOARCH/cgo combination.
    But some combinations can't run the test at all. For example darwin/arm64
    does not run tests with a full source file systems, so it cannot test itself,
    so nothing was testing darwin/arm64. This led to bugs like #10455
    not being caught.
    
    Rewrite the test to read the imports out of the source files ourselves,
    so that we can look at all source files in a directory in one pass,
    regardless of which GOOS/GOARCH/cgo/etc they require.
    This one complete pass runs in the same amount of time as the
    old single combination check ran, so we can now test all systems,
    even in short mode.
    
    Change-Id: Ie216303c2515bbf1b6fb717d530a0636e271cb6d
    Reviewed-on: https://go-review.googlesource.com/12576Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    54a966e3
Name
Last commit
Last update
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...