• Bryan C. Mills's avatar
    cmd/go/internal/modfetch: skip symlinks in (*coderepo).Zip · 561923fa
    Bryan C. Mills authored
    Tested manually.
    
    Before:
    
    	$ go mod init golang.org/issue/scratch
    	go: creating new go.mod: module golang.org/issue/scratch
    	$ go1.11.2 mod download github.com/rogpeppe/test2@latest
    	go: finding github.com/rogpeppe/test2 v0.0.11
    	$ find $GOPATH -name goodbye
    	/tmp/tmp.Y8a8UzX3zD/_gopath/pkg/mod/github.com/rogpeppe/test2@v0.0.11/tests/goodbye
    	$ cat $(find $GOPATH -name goodbye)
    	hello
    
    After:
    
    	$ go mod init golang.org/issue/scratch
    	go: creating new go.mod: module golang.org/issue/scratch
    	$ go mod download github.com/rogpeppe/test2@latest
    	go: finding github.com/rogpeppe/test2 v0.0.11
    	$ find $GOPATH -name goodbye
    	$ find $GOPATH -name hello
    	/tmp/tmp.Zo0jhfLaRs/_gopath/pkg/mod/github.com/rogpeppe/test2@v0.0.11/tests/hello
    
    A proper regression test would require one of:
    • a new entry in the vcs-test server (feasible but tedious, and not easily updated by open-source contributors), or
    • a way to set up an HTTPS proxy in a script_test, or
    • a way to explicitly populate the module cache from the contents of a local repository (#28835).
    
    Fixes #27093
    Updates #28835
    
    Change-Id: I72702a7e791f8815965f0f87c82a30df4d6f0151
    Reviewed-on: https://go-review.googlesource.com/c/153819
    Run-TryBot: Bryan C. Mills <bcmills@google.com>
    Reviewed-by: 's avatarJay Conrod <jayconrod@google.com>
    561923fa
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testdata Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...