• Josh Bleecher Snyder's avatar
    cmd/internal/gc: separate func-only Node fields · 57279ba7
    Josh Bleecher Snyder authored
    Nodes dominate gc's memory usage, but many fields are only used
    for a subset of kinds of nodes. This change pulls out fields
    used only for func-like Nodes. This reduces the size of the
    Node struct on a 64-bit machine from 504 bytes to 416 bytes (-17%).
    
    Compiling the runtime, 1.5% of nodes have a non-nil Func.
    In html/template, 2.7% of nodes have a non-nil Func.
    
    This change introduces an extra alloc and associated GC overhead
    when Func is non-nil. However, when Func is nil, as it almost
    always is, it spares the garbage collector scanning some Node fields.
    Empirically, this change appears to be roughly neutral with regard to GC.
    
    To keep the diff readable, this CL uses an embedded Func field.
    A subsequent CL will unembed the field.
    
    Passes toolstash -cmp.
    
    Change-Id: Ide86aa954b097fb8e6154f0811d3691497477004
    Reviewed-on: https://go-review.googlesource.com/7360Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    57279ba7
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...