• Josh Bleecher Snyder's avatar
    cmd/compile: shrink specialized convT2x call sites · 5848b6c9
    Josh Bleecher Snyder authored
    convT2E16 and other specialized type-to-interface routines
    accept a type/itab argument and return a complete interface value.
    However, we know enough in the routine to do without the type.
    And the caller can construct the interface value using the type.
    
    Doing so shrinks the call sites of ten of the specialized convT2x routines.
    It also lets us unify the empty and non-empty interface routines.
    
    Cuts 12k off cmd/go.
    
    name                         old time/op  new time/op  delta
    ConvT2ESmall-8               2.96ns ± 2%  2.34ns ± 4%  -21.01%  (p=0.000 n=175+189)
    ConvT2EUintptr-8             3.00ns ± 3%  2.34ns ± 4%  -22.02%  (p=0.000 n=189+187)
    ConvT2ELarge-8               21.3ns ± 7%  21.5ns ± 5%   +1.02%  (p=0.000 n=200+197)
    ConvT2ISmall-8               2.99ns ± 4%  2.33ns ± 3%  -21.95%  (p=0.000 n=193+184)
    ConvT2IUintptr-8             3.02ns ± 3%  2.33ns ± 3%  -22.82%  (p=0.000 n=198+190)
    ConvT2ILarge-8               21.7ns ± 5%  22.2ns ± 4%   +2.31%  (p=0.000 n=199+198)
    ConvT2Ezero/zero/16-8        2.96ns ± 2%  2.33ns ± 3%  -21.11%  (p=0.000 n=174+187)
    ConvT2Ezero/zero/32-8        2.96ns ± 1%  2.35ns ± 4%  -20.62%  (p=0.000 n=163+193)
    ConvT2Ezero/zero/64-8        2.99ns ± 2%  2.34ns ± 4%  -21.78%  (p=0.000 n=183+188)
    ConvT2Ezero/zero/str-8       3.27ns ± 3%  2.54ns ± 3%  -22.32%  (p=0.000 n=195+192)
    ConvT2Ezero/zero/slice-8     3.46ns ± 4%  2.81ns ± 3%  -18.96%  (p=0.000 n=197+164)
    ConvT2Ezero/zero/big-8       88.4ns ±20%  90.0ns ±20%   +1.84%  (p=0.000 n=196+198)
    ConvT2Ezero/nonzero/16-8     12.6ns ± 3%  12.3ns ± 3%   -2.34%  (p=0.000 n=167+196)
    ConvT2Ezero/nonzero/32-8     12.3ns ± 4%  11.9ns ± 3%   -2.95%  (p=0.000 n=187+193)
    ConvT2Ezero/nonzero/64-8     14.2ns ± 6%  13.8ns ± 5%   -2.94%  (p=0.000 n=198+199)
    ConvT2Ezero/nonzero/str-8    27.2ns ± 5%  26.8ns ± 5%   -1.33%  (p=0.000 n=200+198)
    ConvT2Ezero/nonzero/slice-8  33.3ns ± 8%  33.1ns ± 6%   -0.82%  (p=0.000 n=199+200)
    ConvT2Ezero/nonzero/big-8    88.8ns ±22%  90.2ns ±18%   +1.58%  (p=0.000 n=200+199)
    
    
    Neligible toolspeed impact.
    
    name        old alloc/op      new alloc/op      delta
    Template         35.4MB ± 0%       35.3MB ± 0%  -0.06%  (p=0.008 n=5+5)
    Unicode          29.1MB ± 0%       29.1MB ± 0%    ~     (p=0.310 n=5+5)
    GoTypes           122MB ± 0%        122MB ± 0%  -0.08%  (p=0.008 n=5+5)
    Compiler          514MB ± 0%        513MB ± 0%  -0.02%  (p=0.008 n=5+5)
    SSA              1.94GB ± 0%       1.94GB ± 0%  -0.01%  (p=0.008 n=5+5)
    Flate            24.2MB ± 0%       24.2MB ± 0%    ~     (p=0.548 n=5+5)
    GoParser         28.5MB ± 0%       28.5MB ± 0%  -0.05%  (p=0.016 n=5+5)
    Reflect          86.3MB ± 0%       86.2MB ± 0%  -0.02%  (p=0.008 n=5+5)
    Tar              34.9MB ± 0%       34.9MB ± 0%    ~     (p=0.095 n=5+5)
    XML              47.1MB ± 0%       47.1MB ± 0%  -0.05%  (p=0.008 n=5+5)
    [Geo mean]       81.0MB            81.0MB       -0.03%
    
    name        old allocs/op     new allocs/op     delta
    Template           349k ± 0%         349k ± 0%  -0.08%  (p=0.008 n=5+5)
    Unicode            340k ± 0%         340k ± 0%    ~     (p=0.111 n=5+5)
    GoTypes           1.28M ± 0%        1.28M ± 0%  -0.09%  (p=0.008 n=5+5)
    Compiler          4.92M ± 0%        4.92M ± 0%  -0.08%  (p=0.008 n=5+5)
    SSA               15.3M ± 0%        15.3M ± 0%  -0.03%  (p=0.008 n=5+5)
    Flate              233k ± 0%         233k ± 0%    ~     (p=0.500 n=5+5)
    GoParser           292k ± 0%         292k ± 0%  -0.06%  (p=0.008 n=5+5)
    Reflect           1.05M ± 0%        1.05M ± 0%  -0.02%  (p=0.008 n=5+5)
    Tar                344k ± 0%         343k ± 0%  -0.06%  (p=0.008 n=5+5)
    XML                430k ± 0%         429k ± 0%  -0.08%  (p=0.008 n=5+5)
    [Geo mean]         809k              809k       -0.05%
    
    name        old object-bytes  new object-bytes  delta
    Template          507kB ± 0%        507kB ± 0%  -0.04%  (p=0.008 n=5+5)
    Unicode           225kB ± 0%        225kB ± 0%    ~     (all equal)
    GoTypes          1.85MB ± 0%       1.85MB ± 0%  -0.08%  (p=0.008 n=5+5)
    Compiler         6.75MB ± 0%       6.75MB ± 0%  +0.01%  (p=0.008 n=5+5)
    SSA              21.4MB ± 0%       21.4MB ± 0%  -0.02%  (p=0.008 n=5+5)
    Flate             328kB ± 0%        328kB ± 0%  -0.03%  (p=0.008 n=5+5)
    GoParser          403kB ± 0%        402kB ± 0%  -0.06%  (p=0.008 n=5+5)
    Reflect          1.41MB ± 0%       1.41MB ± 0%  -0.03%  (p=0.008 n=5+5)
    Tar               457kB ± 0%        457kB ± 0%  -0.05%  (p=0.008 n=5+5)
    XML               601kB ± 0%        600kB ± 0%  -0.16%  (p=0.008 n=5+5)
    [Geo mean]       1.05MB            1.04MB       -0.05%
    
    
    Change-Id: I677a4108c0ecd32617549294036aa84f9214c4fe
    Reviewed-on: https://go-review.googlesource.com/c/147360
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    Reviewed-by: 's avatarMartin Möhrmann <moehrmann@google.com>
    5848b6c9
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testdata Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...