• Austin Clements's avatar
    cmd/compile: fix race on initializing Sym symFunc flag · 5cf2b4c2
    Austin Clements authored
    SSA lowering can create PFUNC ONAME nodes when compiling method calls.
    Since we generally initialize the node's Sym to a func when we set its
    class to PFUNC, we did this here, too. Unfortunately, since SSA
    compilation is concurrent, this can cause a race if two function
    compilations try to initialize the same symbol.
    
    Luckily, we don't need to do this at all, since we're actually just
    wrapping an ONAME node around an existing Sym that's already marked as
    a function symbol.
    
    Fixes the linux-amd64-racecompile builder, which was broken by CL
    147158.
    
    Updates #27539.
    
    Change-Id: I8ddfce6e66a08ce53998c5bfa6f5a423c1ffc1eb
    Reviewed-on: https://go-review.googlesource.com/c/149158
    Run-TryBot: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarDavid Chase <drchase@google.com>
    5cf2b4c2
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...