• Elias Naur's avatar
    misc/ios,cmd/go, runtime/cgo: fix iOS test harness (again) · 7523baed
    Elias Naur authored
    The iOS test harness was recently changed in response to lldb bugs
    to replace breakpoints with the SIGUSR2 signal (CL 34926), and to
    pass the current directory in the test binary arguments (CL 35152).
    Both the signal sending and working directory setup is done from
    the go test driver.
    
    However, the new method doesn't work with tests where a C program is
    the test driver instead of go test: the current working directory
    will not be changed and SIGUSR2 is not raised.
    
    Instead of copying that logic into any C test program, rework the
    test harness (again) to move the setup logic to the early runtime
    cgo setup code. That way, the harness will run even in the library
    build modes.
    
    Then, use the app Info.plist file to pass the working
    directory, removing the need to alter the arguments after running.
    
    Finally, use the SIGINT signal instead of SIGUSR2 to avoid
    manipulating the signal masks or handlers.
    
    Fixes the testcarchive tests on iOS.
    
    With this CL, both darwin/arm and darwin/arm64 passes all.bash.
    
    This CL replaces CL 34926, CL 35152 as well as the fixup CL
    35123 and CL 35255. They are reverted in CLs earlier in the
    relation chain.
    
    Change-Id: I8485c7db1404fbd8daa261efd1ea89e905121a3e
    Reviewed-on: https://go-review.googlesource.com/36090
    Run-TryBot: Elias Naur <elias.naur@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarDavid Crawshaw <crawshaw@golang.org>
    7523baed
Name
Last commit
Last update
..
android Loading commit data...
arm Loading commit data...
cgo Loading commit data...
chrome/gophertool Loading commit data...
git Loading commit data...
ios Loading commit data...
linkcheck Loading commit data...
nacl Loading commit data...
sortac Loading commit data...
swig Loading commit data...
trace Loading commit data...
benchcmp Loading commit data...
editors Loading commit data...