-
Daniel Theophanes authored
Database drivers should be called from a single goroutine to ease driver's design. If a driver chooses to handle context cancels internally it may do so. The sql package violated this agreement when calling Next or NextResultSet. It was possible for a concurrent rollback triggered from a context cancel to call a Tx.Rollback (which takes a driver connection lock) while a Rows.Next is in progress (which does not tack the driver connection lock). The current internal design of the sql package is each call takes roughly two locks: a closemu lock which prevents an disposing of internal resources (assigning nil or removing from lists) and a driver connection lock that prevents calling driver code from multiple goroutines. Fixes #21117 Change-Id: Ie340dc752a503089c27f57ffd43e191534829360 Reviewed-on: https://go-review.googlesource.com/65731Reviewed-by: Ian Lance Taylor <iant@golang.org>
897080d5
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
driver | ||
convert.go | ||
convert_test.go | ||
ctxutil.go | ||
doc.txt | ||
example_test.go | ||
fakedb_test.go | ||
sql.go | ||
sql_test.go |