• Justin Nuß's avatar
    time: Use AppendFormat in Marshal[Text|JSON] · 5f859ba8
    Justin Nuß authored
    The current implementations of MarshalJSON and MarshalText use
    time.Format which returns a string (converted from a byte slice),
    only to convert it back to a byte slice.
    
    Avoid the conversion (and thus an allocation) by directly appending
    the formatted time to a preallocated byte slice, using the new
    AppendFormat function, introduced in golang.org/cl/1760.
    
    This reduces the allocations done in Marshal[Text|JSON] by 50%.
    
    benchmark                old ns/op     new ns/op     delta
    BenchmarkMarshalJSON     626           507           -19.01%
    BenchmarkMarshalText     598           511           -14.55%
    
    benchmark                old allocs     new allocs     delta
    BenchmarkMarshalJSON     2              1              -50.00%
    BenchmarkMarshalText     2              1              -50.00%
    
    benchmark                old bytes     new bytes     delta
    BenchmarkMarshalJSON     96            48            -50.00%
    BenchmarkMarshalText     96            48            -50.00%
    
    Fixes #11025
    
    Change-Id: I468f78d075a6ecc1cdc839df7fb407fbc6ff2e70
    Reviewed-on: https://go-review.googlesource.com/10555Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    5f859ba8
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...