• Cristian Staretu's avatar
    archive/tar: reuse temporary buffer in readHeader · 61ccc1f0
    Cristian Staretu authored
    A temporary 512 bytes buffer is allocated for every call to
    readHeader. This buffer isn't returned to the caller and it could
    be reused to lower the number of memory allocations.
    
    This CL improves it by using a pool and zeroing out the buffer before
    putting it back into the pool.
    
    benchmark                  old ns/op     new ns/op     delta
    BenchmarkListFiles100k     545249903     538832687     -1.18%
    
    benchmark                  old allocs    new allocs    delta
    BenchmarkListFiles100k     2105167       2005692       -4.73%
    
    benchmark                  old bytes     new bytes     delta
    BenchmarkListFiles100k     105903472     54831527      -48.22%
    
    This improvement is very important if your code has to deal with a lot
    of tarballs which contain a lot of files.
    
    LGTM=dsymonds
    R=golang-codereviews, dave, dsymonds, bradfitz
    CC=golang-codereviews
    https://golang.org/cl/108240044
    61ccc1f0
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...