• Josh Bleecher Snyder's avatar
    cmd/compile: speed up hot phi insertion code · 61fb2f6d
    Josh Bleecher Snyder authored
    This speeds up compilation of the code in #8225 by 25%-30%.
    The complexity of the algorithm is unchanged,
    but this shrinks the constant factor so much that it doesn't matter,
    even the size of the giant type switch gets scaled up dramatically.
    
    name       old time/op      new time/op      delta
    Template        218ms ± 5%       217ms ±10%    ~           (p=0.163 n=27+30)
    Unicode        98.2ms ± 6%      97.7ms ±10%    ~           (p=0.150 n=27+29)
    GoTypes         654ms ± 5%       650ms ± 5%    ~           (p=0.350 n=30+30)
    Compiler        2.70s ± 4%       2.68s ± 3%    ~           (p=0.128 n=30+29)
    
    name       old user-ns/op   new user-ns/op   delta
    Template   276user-ms ± 6%  271user-ms ± 7%  -1.83%        (p=0.003 n=29+28)
    Unicode    138user-ms ± 5%  137user-ms ± 4%    ~           (p=0.071 n=27+27)
    GoTypes    881user-ms ± 4%  877user-ms ± 4%    ~           (p=0.423 n=30+30)
    Compiler   3.76user-s ± 4%  3.72user-s ± 2%  -0.84%        (p=0.028 n=30+29)
    
    name       old alloc/op     new alloc/op     delta
    Template       40.7MB ± 0%      40.7MB ± 0%    ~           (p=0.936 n=30+30)
    Unicode        30.8MB ± 0%      30.8MB ± 0%    ~           (p=0.859 n=28+30)
    GoTypes         123MB ± 0%       123MB ± 0%    ~           (p=0.273 n=30+30)
    Compiler        472MB ± 0%       472MB ± 0%    ~           (p=0.432 n=30+30)
    
    name       old allocs/op    new allocs/op    delta
    Template         401k ± 1%        401k ± 1%    ~           (p=0.859 n=30+30)
    Unicode          331k ± 0%        331k ± 1%    ~           (p=0.823 n=28+30)
    GoTypes         1.24M ± 0%       1.24M ± 0%    ~           (p=0.286 n=30+30)
    Compiler        4.26M ± 0%       4.26M ± 0%    ~           (p=0.359 n=30+30)
    
    Change-Id: Ia850065a9a84c07a5b0b4e23c1758b5679498da7
    Reviewed-on: https://go-review.googlesource.com/36112
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    61fb2f6d
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...