• Keith Randall's avatar
    cmd/compile: fix CSE with commutative ops · 6317f92f
    Keith Randall authored
    CSE opportunities were being missed for commutative ops. We used to
    order the args of commutative ops (by arg ID) once at the start of CSE.
    But that may not be enough.
    
    i1 = (Load ptr mem)
    i2 = (Load ptr mem)
    x1 = (Add i1 j)
    x2 = (Add i2 j)
    
    Equivalent commutative ops x1 and x2 may not get their args ordered in
    the same way because because at the start of CSE, we don't know that
    the i values will be CSEd. If x1 and x2 get opposite orders we won't
    CSE them.
    
    Instead, (re)order the args of commutative operations by their
    equivalence class IDs each time we partition an equivalence class.
    
    Change-Id: Ic609fa83b85299782a5e85bf93dc6023fccf4b0c
    Reviewed-on: https://go-review.googlesource.com/33632
    Run-TryBot: Keith Randall <khr@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarTodd Neal <todd@tneal.org>
    6317f92f
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...