• Rob Pike's avatar
    encoding/gob: use simple append-only buffer for encoding · 65dde1ed
    Rob Pike authored
    Bytes buffers have more API and are a little slower. Since appending
    is a key part of the path in encode, using a faster implementation
    speeds things up measurably.
    The couple of positive swings are likely garbage-collection related
    since memory allocation looks different in the benchmark now.
    I am not concerned by them.
    
    benchmark                            old ns/op     new ns/op     delta
    BenchmarkEndToEndPipe                6620          6388          -3.50%
    BenchmarkEndToEndByteBuffer          3548          3600          +1.47%
    BenchmarkEndToEndSliceByteBuffer     336678        367980        +9.30%
    BenchmarkEncodeComplex128Slice       78199         71297         -8.83%
    BenchmarkEncodeFloat64Slice          37731         32258         -14.51%
    BenchmarkEncodeInt32Slice            26780         22977         -14.20%
    BenchmarkEncodeStringSlice           35882         26492         -26.17%
    BenchmarkDecodeComplex128Slice       194819        185126        -4.98%
    BenchmarkDecodeFloat64Slice          120538        120102        -0.36%
    BenchmarkDecodeInt32Slice            106442        107275        +0.78%
    BenchmarkDecodeStringSlice           272902        269866        -1.11%
    
    LGTM=ruiu
    R=golang-codereviews, ruiu
    CC=golang-codereviews
    https://golang.org/cl/160990043
    65dde1ed
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal/syscall Loading commit data...
io Loading commit data...
lib9 Loading commit data...
libbio Loading commit data...
liblink Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...
sudo.bash Loading commit data...