• Dmitry Vyukov's avatar
    cmd/gc: capture variables by value · 0e80b2e0
    Dmitry Vyukov authored
    Language specification says that variables are captured by reference.
    And that is what gc compiler does. However, in lots of cases it is
    possible to capture variables by value under the hood without
    affecting visible behavior of programs. For example, consider
    the following typical pattern:
    
    	func (o *Obj) requestMany(urls []string) []Result {
    		wg := new(sync.WaitGroup)
    		wg.Add(len(urls))
    		res := make([]Result, len(urls))
    		for i := range urls {
    			i := i
    			go func() {
    				res[i] = o.requestOne(urls[i])
    				wg.Done()
    			}()
    		}
    		wg.Wait()
    		return res
    	}
    
    Currently o, wg, res, and i are captured by reference causing 3+len(urls)
    allocations (e.g. PPARAM o is promoted to PPARAMREF and moved to heap).
    But all of them can be captured by value without changing behavior.
    
    This change implements simple strategy for capturing by value:
    if a captured variable is not addrtaken and never assigned to,
    then it is captured by value (it is effectively const).
    This simple strategy turned out to be very effective:
    ~80% of all captures in std lib are turned into value captures.
    The remaining 20% are mostly in defers and non-escaping closures,
    that is, they do not cause allocations anyway.
    
    benchmark                                    old allocs     new allocs     delta
    BenchmarkCompressedZipGarbage                153            126            -17.65%
    BenchmarkEncodeDigitsSpeed1e4                91             69             -24.18%
    BenchmarkEncodeDigitsSpeed1e5                178            129            -27.53%
    BenchmarkEncodeDigitsSpeed1e6                1510           1051           -30.40%
    BenchmarkEncodeDigitsDefault1e4              100            75             -25.00%
    BenchmarkEncodeDigitsDefault1e5              193            139            -27.98%
    BenchmarkEncodeDigitsDefault1e6              1420           985            -30.63%
    BenchmarkEncodeDigitsCompress1e4             100            75             -25.00%
    BenchmarkEncodeDigitsCompress1e5             193            139            -27.98%
    BenchmarkEncodeDigitsCompress1e6             1420           985            -30.63%
    BenchmarkEncodeTwainSpeed1e4                 109            81             -25.69%
    BenchmarkEncodeTwainSpeed1e5                 211            151            -28.44%
    BenchmarkEncodeTwainSpeed1e6                 1588           1097           -30.92%
    BenchmarkEncodeTwainDefault1e4               103            77             -25.24%
    BenchmarkEncodeTwainDefault1e5               199            143            -28.14%
    BenchmarkEncodeTwainDefault1e6               1324           917            -30.74%
    BenchmarkEncodeTwainCompress1e4              103            77             -25.24%
    BenchmarkEncodeTwainCompress1e5              190            137            -27.89%
    BenchmarkEncodeTwainCompress1e6              1327           919            -30.75%
    BenchmarkConcurrentDBExec                    16223          16220          -0.02%
    BenchmarkConcurrentStmtQuery                 17687          16182          -8.51%
    BenchmarkConcurrentStmtExec                  5191           5186           -0.10%
    BenchmarkConcurrentTxQuery                   17665          17661          -0.02%
    BenchmarkConcurrentTxExec                    15154          15150          -0.03%
    BenchmarkConcurrentTxStmtQuery               17661          16157          -8.52%
    BenchmarkConcurrentTxStmtExec                3677           3673           -0.11%
    BenchmarkConcurrentRandom                    14000          13614          -2.76%
    BenchmarkManyConcurrentQueries               25             22             -12.00%
    BenchmarkDecodeComplex128Slice               318            252            -20.75%
    BenchmarkDecodeFloat64Slice                  318            252            -20.75%
    BenchmarkDecodeInt32Slice                    318            252            -20.75%
    BenchmarkDecodeStringSlice                   2318           2252           -2.85%
    BenchmarkDecode                              11             8              -27.27%
    BenchmarkEncodeGray                          64             56             -12.50%
    BenchmarkEncodeNRGBOpaque                    64             56             -12.50%
    BenchmarkEncodeNRGBA                         67             58             -13.43%
    BenchmarkEncodePaletted                      68             60             -11.76%
    BenchmarkEncodeRGBOpaque                     64             56             -12.50%
    BenchmarkGoLookupIP                          153            139            -9.15%
    BenchmarkGoLookupIPNoSuchHost                508            466            -8.27%
    BenchmarkGoLookupIPWithBrokenNameServer      245            226            -7.76%
    BenchmarkClientServer                        62             59             -4.84%
    BenchmarkClientServerParallel4               62             59             -4.84%
    BenchmarkClientServerParallel64              62             59             -4.84%
    BenchmarkClientServerParallelTLS4            79             76             -3.80%
    BenchmarkClientServerParallelTLS64           112            109            -2.68%
    BenchmarkCreateGoroutinesCapture             10             6              -40.00%
    BenchmarkAfterFunc                           1006           1005           -0.10%
    
    Fixes #6632.
    
    Change-Id: I0cd51e4d356331d7f3c5f447669080cd19b0d2ca
    Reviewed-on: https://go-review.googlesource.com/3166Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    0e80b2e0
Name
Last commit
Last update
..
bench Loading commit data...
bugs Loading commit data...
chan Loading commit data...
ddd2.dir Loading commit data...
dwarf Loading commit data...
fixedbugs Loading commit data...
import2.dir Loading commit data...
import4.dir Loading commit data...
interface Loading commit data...
ken Loading commit data...
method4.dir Loading commit data...
safe Loading commit data...
stress Loading commit data...
syntax Loading commit data...
235.go Loading commit data...
64bit.go Loading commit data...
alias.go Loading commit data...
alias1.go Loading commit data...
append.go Loading commit data...
args.go Loading commit data...
assign.go Loading commit data...
assign1.go Loading commit data...
bigalg.go Loading commit data...
bigmap.go Loading commit data...
blank.go Loading commit data...
blank1.go Loading commit data...
bom.go Loading commit data...
bombad.go Loading commit data...
bounds.go Loading commit data...
chancap.go Loading commit data...
chanlinear.go Loading commit data...
char_lit.go Loading commit data...
char_lit1.go Loading commit data...
clearfat.go Loading commit data...
closedchan.go Loading commit data...
closure.go Loading commit data...
closure1.go Loading commit data...
closure2.go Loading commit data...
cmp.go Loading commit data...
cmp6.go Loading commit data...
cmplx.go Loading commit data...
cmplxdivide.c Loading commit data...
cmplxdivide.go Loading commit data...
cmplxdivide1.go Loading commit data...
complit.go Loading commit data...
complit1.go Loading commit data...
compos.go Loading commit data...
const.go Loading commit data...
const1.go Loading commit data...
const2.go Loading commit data...
const3.go Loading commit data...
const4.go Loading commit data...
const5.go Loading commit data...
const6.go Loading commit data...
convT2X.go Loading commit data...
convert.go Loading commit data...
convert1.go Loading commit data...
convert3.go Loading commit data...
convlit.go Loading commit data...
convlit1.go Loading commit data...
copy.go Loading commit data...
crlf.go Loading commit data...
ddd.go Loading commit data...
ddd1.go Loading commit data...
ddd2.go Loading commit data...
decl.go Loading commit data...
declbad.go Loading commit data...
defer.go Loading commit data...
deferfin.go Loading commit data...
deferprint.go Loading commit data...
deferprint.out Loading commit data...
divide.go Loading commit data...
divmod.go Loading commit data...
empty.go Loading commit data...
env.go Loading commit data...
eof.go Loading commit data...
eof1.go Loading commit data...
errchk Loading commit data...
escape.go Loading commit data...
escape2.go Loading commit data...
escape2n.go Loading commit data...
escape3.go Loading commit data...
escape4.go Loading commit data...
escape5.go Loading commit data...
fibo.go Loading commit data...
float_lit.go Loading commit data...
float_lit2.go Loading commit data...
float_lit3.go Loading commit data...
floatcmp.go Loading commit data...
for.go Loading commit data...
func.go Loading commit data...
func1.go Loading commit data...
func2.go Loading commit data...
func3.go Loading commit data...
func4.go Loading commit data...
func5.go Loading commit data...
func6.go Loading commit data...
func7.go Loading commit data...
func8.go Loading commit data...
funcdup.go Loading commit data...
funcdup2.go Loading commit data...
gc.go Loading commit data...
gc1.go Loading commit data...
gc2.go Loading commit data...
gcstring.go Loading commit data...
goprint.go Loading commit data...
goprint.out Loading commit data...
goto.go Loading commit data...
helloworld.go Loading commit data...
helloworld.out Loading commit data...
if.go Loading commit data...
import.go Loading commit data...
import1.go Loading commit data...
import2.go Loading commit data...
import4.go Loading commit data...
import5.go Loading commit data...
index.go Loading commit data...
index0.go Loading commit data...
index1.go Loading commit data...
index2.go Loading commit data...
indirect.go Loading commit data...
indirect1.go Loading commit data...
init.go Loading commit data...
init1.go Loading commit data...
initcomma.go Loading commit data...
initialize.go Loading commit data...
initializerr.go Loading commit data...
int_lit.go Loading commit data...
intcvt.go Loading commit data...
iota.go Loading commit data...
label.go Loading commit data...
label1.go Loading commit data...
linkx.go Loading commit data...
linkx_run.go Loading commit data...
literal.go Loading commit data...
live.go Loading commit data...
live1.go Loading commit data...
live2.go Loading commit data...
mallocfin.go Loading commit data...
map.go Loading commit data...
map1.go Loading commit data...
maplinear.go Loading commit data...
method.go Loading commit data...
method1.go Loading commit data...
method2.go Loading commit data...
method3.go Loading commit data...
method4.go Loading commit data...
method5.go Loading commit data...
named.go Loading commit data...
named1.go Loading commit data...
nil.go Loading commit data...
nilcheck.go Loading commit data...
nilptr.go Loading commit data...
nilptr2.go Loading commit data...
nilptr3.go Loading commit data...
nilptr4.go Loading commit data...
nosplit.go Loading commit data...
nul1.go Loading commit data...
parentype.go Loading commit data...
peano.go Loading commit data...
print.go Loading commit data...
print.out Loading commit data...
printbig.go Loading commit data...
printbig.out Loading commit data...
range.go Loading commit data...
recover.go Loading commit data...
recover1.go Loading commit data...
recover2.go Loading commit data...
recover3.go Loading commit data...
rename.go Loading commit data...
rename1.go Loading commit data...
reorder.go Loading commit data...
reorder2.go Loading commit data...
return.go Loading commit data...
rotate.go Loading commit data...
rotate0.go Loading commit data...
rotate1.go Loading commit data...
rotate2.go Loading commit data...
rotate3.go Loading commit data...
run.go Loading commit data...
rune.go Loading commit data...
runtime.go Loading commit data...
shift1.go Loading commit data...
shift2.go Loading commit data...
sieve.go Loading commit data...
sigchld.go Loading commit data...
sigchld.out Loading commit data...
simassign.go Loading commit data...
sinit.go Loading commit data...
sinit_run.go Loading commit data...
sizeof.go Loading commit data...
slice3.go Loading commit data...
slice3err.go Loading commit data...
slicecap.go Loading commit data...
solitaire.go Loading commit data...
stack.go Loading commit data...
string_lit.go Loading commit data...
stringrange.go Loading commit data...
struct0.go Loading commit data...
switch.go Loading commit data...
switch3.go Loading commit data...
switch4.go Loading commit data...
tinyfin.go Loading commit data...
torture.go Loading commit data...
turing.go Loading commit data...
typecheck.go Loading commit data...
typeswitch.go Loading commit data...
typeswitch1.go Loading commit data...
typeswitch2.go Loading commit data...
typeswitch3.go Loading commit data...
undef.go Loading commit data...
utf.go Loading commit data...
varerr.go Loading commit data...
varinit.go Loading commit data...
zerodivide.go Loading commit data...