• Russ Cox's avatar
    cmd/pprof: never use c++filt · a25c403b
    Russ Cox authored
    The copy of c++filt shipped on OS X is six years old,
    and in our case it does far more mangling than it
    does demangling. People on non-OS X systems will
    have a working nm --demangle, so this won't affect them.
    
    $ sw_vers
    ProductName:	Mac OS X
    ProductVersion:	10.8.2
    BuildVersion:	12C2034
    $ c++filt --version
    GNU c++filt 070207 20070207
    Copyright 2005 Free Software Foundation, Inc.
    This program is free software; you may redistribute it under the terms of
    the GNU General Public License.  This program has absolutely no warranty.
    $
    
    $ go tool nm -n revcomp | grep quoteWith
       4f560 T strconv.quoteWith
    $ go tool nm -n revcomp | grep quoteWith  | c++filt
       f560 T strconv.quoteWith
    $
    
    $ nm -n revcomp | grep quoteWith
    000000000004f560 t _strconv.quoteWith
    $ nm -n revcomp | grep quoteWith | c++filt
    000000000004f560 unsigned short _strconv.quoteWith
    $
    
    Fixes #4818.
    
    R=golang-dev, r, bradfitz
    CC=golang-dev
    https://golang.org/cl/7729043
    a25c403b
Name
Last commit
Last update
..
IntelliJIDEA Loading commit data...
arm Loading commit data...
bash Loading commit data...
bbedit Loading commit data...
cgo Loading commit data...
chrome/gophertool Loading commit data...
dashboard Loading commit data...
dist Loading commit data...
emacs Loading commit data...
fraise Loading commit data...
git Loading commit data...
goplay Loading commit data...
kate Loading commit data...
notepadplus Loading commit data...
swig Loading commit data...
vim Loading commit data...
xcode Loading commit data...
zsh Loading commit data...
benchcmp Loading commit data...
pprof Loading commit data...