• Russ Cox's avatar
    cmd/go: update TestGoGetUpdateWithWildcard expected behavior · 714c141c
    Russ Cox authored
    If you run
    
    	go get -u github.com/rsc/foo/bar...
    
    then the go get command has always worked hard to make sure
    that it applies the wildcard after downloading rsc/foo.
    (If it applied the wildcard only before downloading rsc/foo,
    it would match nothing if you had an empty GOPATH before,
    and you'd still have an empty afterward, which is clearly useless.)
    
    The goal has always been that if you run the same go get
    command twice, the second command doesn't find anything
    new to do.
    
    CL 19892 worked around an "internal error" failure but broke
    the rule about the first command doing everything the second
    command would. Suppose you had github.com/rsc/foo already,
    with just github.com/rsc/foo/bar, and you run
    
    	go get -u github.com/rsc/...
    
    The wildcard first matches github.com/rsc/foo/bar, but suppose
    updating the repo pulls down github.com/rsc/foo/baz, which
    in turn depends on the non-existent package github.com/rsc/quux.
    We need to reevaluate the wildcard after the download.
    
    The new pattern match refactoring makes this easier and happened
    to have corrected the behavior, but we missed a long test that
    expected the old behavior.
    
    Fix that long test.
    
    Change-Id: I088473e7a90925e5c0f9697da9554a11456ddd08
    Reviewed-on: https://go-review.googlesource.com/129796
    Run-TryBot: Russ Cox <rsc@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    714c141c
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...