• Russ Cox's avatar
    cmd/go: always build _test.go files and link into test · 754cd541
    Russ Cox authored
    go test's handling of _test.go files when the entire
    package's set of files has no Test functions has varied
    over the past few releases. There are a few interesting
    cases (all contain no Test functions):
            (1) x_test.go has syntax errors
            (2) x_test.go has type errors
            (3) x_test.go has runtime errors (say, a func init that panics)
    
    In Go 1.1, tests with (1) or (2) failed; (3) passed.
    In Go 1.2, tests with (1) or (2) failed; (3) passed.
    In Go 1.3, tests with (1) failed; (2) or (3) passed.
    After this CL, tests with (1), (2), or (3) all fail.
    
    This is clearly a corner case, but it seems to me that
    the behavior of the test should not change if you
    add or remove a line like
    
            func TestAlwaysPasses(t *testing.T) {}
    
    That implies that the _test.go files must always
    be built and always be imported into the test binary.
    Doing so means that (1), (2), and (3) must all fail.
    
    Fixes #8337.
    
    LGTM=iant
    R=golang-codereviews, iant
    CC=adg, golang-codereviews, r
    https://golang.org/cl/150980043
    754cd541
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal/syscall Loading commit data...
io Loading commit data...
lib9 Loading commit data...
libbio Loading commit data...
liblink Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...
sudo.bash Loading commit data...