• Dmitriy Vyukov's avatar
    sync: fix race instrumentation of WaitGroup · 07cb48c3
    Dmitriy Vyukov authored
    Currently more than 1 gorutine can execute raceWrite() in Wait()
    in the following scenario:
    1. goroutine 1 executes first check of wg.counter, sees that it's == 0
    2. goroutine 2 executes first check of wg.counter, sees that it's == 0
    3. goroutine 2 locks the mutex, sees that he is the first waiter and executes raceWrite()
    4. goroutine 2 block on the semaphore
    5. goroutine 3 executes Done() and unblocks goroutine 2
    6. goroutine 1 lock the mutex, sees that he is the first waiter and executes raceWrite()
    
    It produces the following false report:
    WARNING: DATA RACE
    Write by goroutine 35:
      sync.raceWrite()
          src/pkg/sync/race.go:41 +0x33
      sync.(*WaitGroup).Wait()
          src/pkg/sync/waitgroup.go:103 +0xae
      command-line-arguments_test.TestNoRaceWaitGroupMultipleWait2()
          src/pkg/runtime/race/testdata/waitgroup_test.go:156 +0x19a
      testing.tRunner()
          src/pkg/testing/testing.go:361 +0x108
    
    Previous write by goroutine 36:
      sync.raceWrite()
          src/pkg/sync/race.go:41 +0x33
      sync.(*WaitGroup).Wait()
          src/pkg/sync/waitgroup.go:103 +0xae
      command-line-arguments_test.func·012()
          src/pkg/runtime/race/testdata/waitgroup_test.go:148 +0x4d
    
    R=golang-dev, r
    CC=golang-dev
    https://golang.org/cl/10424043
    07cb48c3
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...