• Alexandru Moșoi's avatar
    cmd/compile: reenable phielim during rewrite · 7879e919
    Alexandru Moșoi authored
    Remove the "optimization" that was causing the issue.
    
    For the following code the "optimization" was
    converting v to (OpCopy x) which is wrong because
    x doesn't dominate v.
    
    b1:
        y = ...
        First .. b3
    b2:
       x = ...
       Goto b3
    b3:
       v = phi x y
       ... use v ...
    
    That "optimization" is likely no longer needed because
    we now have a second opt pass with a dce in between
    which removes blocks of type First.
    
    For pkg/tools/linux_amd64/* the binary size drops
    from 82142886 to 82060034.
    
    Change-Id: I10428abbd8b32c5ca66fec3da2e6f3686dddbe31
    Reviewed-on: https://go-review.googlesource.com/22312
    Run-TryBot: Alexandru Moșoi <alexandru@mosoi.ro>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    7879e919
Name
Last commit
Last update
..
amd64 Loading commit data...
arm Loading commit data...
arm64 Loading commit data...
big Loading commit data...
gc Loading commit data...
mips64 Loading commit data...
ppc64 Loading commit data...
s390x Loading commit data...
ssa Loading commit data...
x86 Loading commit data...