• Artyom Pervukhin's avatar
    image/draw, image/color: optimize hot path sqDiff function · 7a8e8b2f
    Artyom Pervukhin authored
    Function sqDiff is called multiple times in the hot path (x, y loops) of
    drawPaletted from the image/draw package; number of sqDiff calls is
    between 4×width×height and 4×width×height×len(palette) for each
    drawPaletted call.
    
    Simplify this function by removing arguments comparison and relying
    instead on signed to unsigned integer conversion rules and properties of
    unsigned integer values operations guaranteed by the spec:
    
    > For unsigned integer values, the operations +, -, *, and << are
    > computed modulo 2n, where n is the bit width of the unsigned integer's
    > type. Loosely speaking, these unsigned integer operations discard high
    > bits upon overflow, and programs may rely on ``wrap around''.
    
    image/gif package benchmark that depends on the code updated shows
    throughput improvements:
    
    name               old time/op    new time/op    delta
    QuantizedEncode-4     788ms ± 2%     468ms ± 9%  -40.58%  (p=0.000 n=9+10)
    
    name               old speed      new speed      delta
    QuantizedEncode-4  1.56MB/s ± 2%  2.63MB/s ± 8%  +68.47%  (p=0.000 n=9+10)
    
    Closes #22375.
    
    Change-Id: Ic9a540e39ceb21e7741d308af1cfbe61b4ac347b
    Reviewed-on: https://go-review.googlesource.com/72373Reviewed-by: 's avatarNigel Tao <nigeltao@golang.org>
    7a8e8b2f
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...