• Matthew Dempsky's avatar
    cmd/compile: fix method set computation for shadowed methods · 7b177b1a
    Matthew Dempsky authored
    In expandmeth, we call expand1/expand0 to build a list of all
    candidate methods to promote, and then we use dotpath to prune down
    which names actually resolve to a promoted method and how.
    
    However, previously we still computed "followsptr" based on the
    expand1/expand0 traversal (which is depth-first), rather than
    dotpath (which is breadth-first). The result is that we could
    sometimes end up miscomputing whether a particular promoted method
    involves a pointer traversal, which could result in bad code
    generation for method trampolines.
    
    Fixes #24547.
    
    Change-Id: I57dc014466d81c165b05d78b98610dc3765b7a90
    Reviewed-on: https://go-review.googlesource.com/102618Reviewed-by: 's avatarRobert Griesemer <gri@golang.org>
    7b177b1a
Name
Last commit
Last update
..
addr2line Loading commit data...
api Loading commit data...
asm Loading commit data...
buildid Loading commit data...
cgo Loading commit data...
compile Loading commit data...
cover Loading commit data...
dist Loading commit data...
doc Loading commit data...
fix Loading commit data...
go Loading commit data...
gofmt Loading commit data...
internal Loading commit data...
link Loading commit data...
nm Loading commit data...
objdump Loading commit data...
pack Loading commit data...
pprof Loading commit data...
test2json Loading commit data...
trace Loading commit data...
vendor Loading commit data...
vet Loading commit data...