• Lynn Boger's avatar
    cmd/asm: detect invalid DS form offsets for ppc64x · 7d4cca07
    Lynn Boger authored
    While debugging a recent regression it was discovered that
    the assembler for ppc64x was not always generating the correct
    instruction for DS form loads and stores.  When an instruction
    is DS form then the offset must be a multiple of 4, and if it
    isn't then bits outside the offset field were being incorrectly
    set resulting in unexpected and incorrect instructions.
    
    This change adds a check to determine when the opcode is DS form
    and then verifies that the offset is a multiple of 4 before
    generating the instruction, otherwise logs an error.
    
    This also changes a few asm files that were using unaligned offsets
    for DS form loads and stores.  In the runtime package these were
    instructions intended to cause a crash so using aligned or unaligned
    offsets doesn't change that behavior.
    
    Change-Id: Ie3a7e1e65dcc9933b54de7a46a054da8459cb56f
    Reviewed-on: https://go-review.googlesource.com/40476Reviewed-by: 's avatarMichael Hudson-Doyle <michael.hudson@canonical.com>
    7d4cca07
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...