• haya14busa's avatar
    regexp: reduce allocs in regexp.Match for onepass regex · 8a16d7d4
    haya14busa authored
    There were no allocations in regexp.Match for *non* onepass regex
    because m.matchcap length is reset to zero (ncap=0 for regexp.Match).
    
    But, as for onepass regex, m.matchcap length remains as it is even when
    ncap=0 and it leads needless allocations.
    
    benchmark                                    old ns/op      new ns/op      delta
    BenchmarkMatch_onepass_regex/32-4      6465           4628           -28.41%
    BenchmarkMatch_onepass_regex/1K-4      208324         151558         -27.25%
    BenchmarkMatch_onepass_regex/32K-4     7230259        5834492        -19.30%
    BenchmarkMatch_onepass_regex/1M-4      234379810      166310682      -29.04%
    BenchmarkMatch_onepass_regex/32M-4     7903529363     4981119950     -36.98%
    
    benchmark                                    old MB/s     new MB/s     speedup
    BenchmarkMatch_onepass_regex/32-4      4.95         6.91         1.40x
    BenchmarkMatch_onepass_regex/1K-4      4.92         6.76         1.37x
    BenchmarkMatch_onepass_regex/32K-4     4.53         5.62         1.24x
    BenchmarkMatch_onepass_regex/1M-4      4.47         6.30         1.41x
    BenchmarkMatch_onepass_regex/32M-4     4.25         6.74         1.59x
    
    benchmark                                    old allocs     new allocs     delta
    BenchmarkMatch_onepass_regex/32-4      32             0              -100.00%
    BenchmarkMatch_onepass_regex/1K-4      1024           0              -100.00%
    BenchmarkMatch_onepass_regex/32K-4     32768          0              -100.00%
    BenchmarkMatch_onepass_regex/1M-4      1048576        0              -100.00%
    BenchmarkMatch_onepass_regex/32M-4     104559255      0              -100.00%
    
    benchmark                                    old bytes      new bytes     delta
    BenchmarkMatch_onepass_regex/32-4      512            0             -100.00%
    BenchmarkMatch_onepass_regex/1K-4      16384          0             -100.00%
    BenchmarkMatch_onepass_regex/32K-4     524288         0             -100.00%
    BenchmarkMatch_onepass_regex/1M-4      16777216       0             -100.00%
    BenchmarkMatch_onepass_regex/32M-4     2019458128     0             -100.00%
    
    Fixes #19573
    
    Change-Id: I033982d0003ebb0360bb40b92eb3941c781ec74d
    Reviewed-on: https://go-review.googlesource.com/38270
    Run-TryBot: Michael Matloob <matloob@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    8a16d7d4
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...