• Matthew Dempsky's avatar
    cmd/internal/gc: remove namebuf variable · 8b3670ff
    Matthew Dempsky authored
    namebuf was a global char buffer in the C version of gc, which was
    useful for providing common storage for constructing symbol and file
    names.  However, now that it's just a global Go string and the string
    data is dynamically allocated anyway, it doesn't serve any purpose
    except to force extra write barriers everytime it's assigned to.
    
    Also, introduce Lookupf(fmt, args...) as shorthand for
    Lookup(fmt.Sprintf(fmt, args...)), which was a very common pattern for
    using namebuf.
    
    Passes "go build -toolexec 'toolstash -cmp' -a std".
    
    Notably, this CL shrinks 6g's text section by ~15kB:
    
    $ size toolstash/6g tool/linux_amd64/6g
       text	   data	    bss	    dec	    hex	filename
    4600805	 605968	 342988	5549761	 54aec1	toolstash/6g
    4585547	 605968	 342956	5534471	 547307	tool/linux_amd64/6g
    
    Change-Id: I98abb44fc7f43a2e2e48425cc9f215cd0be37442
    Reviewed-on: https://go-review.googlesource.com/7080Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    8b3670ff
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...