• Bryan C. Mills's avatar
    runtime: make Playground timestamps change when the stream fd changes · 8e43c372
    Bryan C. Mills authored
    The process reading the output of the binary may read stderr and
    stdout separately, and may interleave reads from the two streams
    arbitrarily. Because we explicitly serialize writes on the writer
    side, we can reuse a timestamp within a single stream without losing
    information; however, if we use the same timestamp for write on both
    streams, the reader can't tell how to interleave them.
    
    This change ensures that every time we change between the two fds, we
    also bump the timestamp. That way, writes within a stream continue to
    show the same timestamp, but a sorted merge of the contents of the two
    streams always interleaves them in the correct order.
    
    This still requires a corresponding change to the Playground parser to
    actually reconstruct the correct interleaving. It currently merges the
    two streams without reordering them; it should instead buffer them
    separately and perform a sorted merge. (See
    https://golang.org/cl/105496.)
    
    Updates golang/go#24615.
    Updates golang/go#24659.
    
    Change-Id: Id789dfcc02eb4247906c9ddad38dac50cf829979
    Reviewed-on: https://go-review.googlesource.com/105235
    Run-TryBot: Bryan C. Mills <bcmills@google.com>
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarYury Smolsky <yury@smolsky.by>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    8e43c372
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...