• Josh Bleecher Snyder's avatar
    testing: only call ReadMemStats if necessary when benchmarking · 948b21a3
    Josh Bleecher Snyder authored
    When running benchmarks with -cpuprofile,
    the entire process gets profiled,
    and ReadMemStats is surprisingly expensive.
    Running the sort benchmarks right now with
    -cpuprofile shows almost half of all execution
    time in ReadMemStats.
    
    Since ReadMemStats is not required if the benchmark
    does not need allocation stats, simply skip it.
    This will make cpu profiles nicer to read
    and significantly speed up the process of running benchmarks.
    It might also make sense to toggle cpu profiling
    on/off as we begin/end individual benchmarks,
    but that wouldn't get us the time savings of
    skipping ReadMemStats, so this CL is useful in itself.
    
    Change-Id: I425197b1ee11be4bc91d22b929e2caf648ebd7c5
    Reviewed-on: https://go-review.googlesource.com/36791
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    948b21a3
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...