• Daniel Martí's avatar
    cmd/compile: fix racy setting of gc's Config.Race · c1807989
    Daniel Martí authored
    ssaConfig.Race was being set by many goroutines concurrently, resulting
    in a data race seen below. This was very likely introduced by CL 121235.
    
    	WARNING: DATA RACE
    	Write at 0x00c000344408 by goroutine 12:
    	  cmd/compile/internal/gc.buildssa()
    	      /workdir/go/src/cmd/compile/internal/gc/ssa.go:134 +0x7a8
    	  cmd/compile/internal/gc.compileSSA()
    	      /workdir/go/src/cmd/compile/internal/gc/pgen.go:259 +0x5d
    	  cmd/compile/internal/gc.compileFunctions.func2()
    	      /workdir/go/src/cmd/compile/internal/gc/pgen.go:323 +0x5a
    
    	Previous write at 0x00c000344408 by goroutine 11:
    	  cmd/compile/internal/gc.buildssa()
    	      /workdir/go/src/cmd/compile/internal/gc/ssa.go:134 +0x7a8
    	  cmd/compile/internal/gc.compileSSA()
    	      /workdir/go/src/cmd/compile/internal/gc/pgen.go:259 +0x5d
    	  cmd/compile/internal/gc.compileFunctions.func2()
    	      /workdir/go/src/cmd/compile/internal/gc/pgen.go:323 +0x5a
    
    	Goroutine 12 (running) created at:
    	  cmd/compile/internal/gc.compileFunctions()
    	      /workdir/go/src/cmd/compile/internal/gc/pgen.go:321 +0x39b
    	  cmd/compile/internal/gc.Main()
    	      /workdir/go/src/cmd/compile/internal/gc/main.go:651 +0x437d
    	  main.main()
    	      /workdir/go/src/cmd/compile/main.go:51 +0x100
    
    	Goroutine 11 (running) created at:
    	  cmd/compile/internal/gc.compileFunctions()
    	      /workdir/go/src/cmd/compile/internal/gc/pgen.go:321 +0x39b
    	  cmd/compile/internal/gc.Main()
    	      /workdir/go/src/cmd/compile/internal/gc/main.go:651 +0x437d
    	  main.main()
    	      /workdir/go/src/cmd/compile/main.go:51 +0x100
    
    Instead, set up the field exactly once as part of initssaconfig.
    
    Change-Id: I2c30c6b1cf92b8fd98e7cb5c2e10c526467d0b0a
    Reviewed-on: https://go-review.googlesource.com/130375
    Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarDave Cheney <dave@cheney.net>
    c1807989
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...