• Robert Griesemer's avatar
    strconv: use % instead of computing the remainder from the quotient · 95c5227c
    Robert Griesemer authored
    The compiler recognizes that in a sequence q = x/y; r = x%y only
    one division is required. Remove prior work-arounds and write
    more readable straight-line code (this also results in fewer
    instructions, though it doesn't appear to affect the benchmarks
    significantly).
    
    name          old time/op  new time/op  delta
    FormatInt-8   2.95µs ± 1%  2.92µs ± 5%   ~     (p=0.952 n=5+5)
    AppendInt-8   1.91µs ± 1%  1.89µs ± 2%   ~     (p=0.421 n=5+5)
    FormatUint-8   795ns ± 2%   782ns ± 4%   ~     (p=0.444 n=5+5)
    AppendUint-8   557ns ± 1%   557ns ± 2%   ~     (p=0.548 n=5+5)
    
    https://perf.golang.org/search?q=upload:20170310.1
    
    Also:
    - use uint instead of uintptr where we want to guarantee single-
      register operations
    - remove some unnecessary conversions (before indexing)
    - add more comments and fix some comments
    
    Change-Id: I04858dc2d798a6495879d9c7cfec2fdc2957b704
    Reviewed-on: https://go-review.googlesource.com/38071Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    95c5227c
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...