• David Crawshaw's avatar
    cmd/link: only exclude C-only symbols on darwin · 9cf06ed6
    David Crawshaw authored
    C-only symbols are excluded from pclntab because of a quirk of darwin,
    where functions are referred to by an exported symbol so dynamic
    relocations de-duplicate to the host binary module and break unwinding.
    
    This doesn't happen on ELF systems because the linker always refers to
    unexported module-local symbols, so we don't need this condition.
    And the current logic for excluding some functions breaks the module
    verification code in moduledataverify1. So disable this for plugins
    on linux.
    
    (In 1.9, it will probably be necessary to introduce a module-local
    symbol reference system on darwin to fix a different bug, so all of
    this onlycsymbol code made be short-lived.)
    
    With this CL, the tests in CL 35116 pass.
    
    Change-Id: I517d7ca4427241fa0a91276c462827efb9383be9
    Reviewed-on: https://go-review.googlesource.com/35190Reviewed-by: 's avatarMichael Hudson-Doyle <michael.hudson@canonical.com>
    Run-TryBot: David Crawshaw <crawshaw@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    9cf06ed6
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...